Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/7.0] System.Console: allow terminfo files to be larger than 4KiB. #82082

Merged
merged 2 commits into from
Mar 8, 2023
Merged

[release/7.0] System.Console: allow terminfo files to be larger than 4KiB. #82082

merged 2 commits into from
Mar 8, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Feb 14, 2023 •
edited by adamsitnik
Loading

Backport of #82038 to release/7.0

Customer Impact

Upcoming Fedora 38 provides a TermInfo file which is larger than artificial limit we have set in .NET Core 1.0. Usage of any Console APIs ends up with an exception. This PR removes the max file size check.

Testing

@tmds has provided the fix and tested the changes on Fedora 38.

Risk

I can't think of any, as TermInfo files are stored in a secure location.

No OOB changes needed for System.Console.

@ghost
Copy link

ghost commented Feb 14, 2023

Tagging subscribers to this area: @dotnet/area-system-console
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #82038 to release/7.0

/cc @adamsitnik @tmds

Customer Impact

Testing

Risk

IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.

Author: github-actions[bot]
Assignees: -
Labels:

area-System.Console
Milestone: -

@adamsitnik adamsitnik added the Servicing-consider Issue for next servicing release review label Feb 21, 2023
@adamsitnik adamsitnik added this to the 7.0.x milestone Feb 21, 2023
@leecow leecow added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Feb 21, 2023
@leecow leecow modified the milestones: 7.0.x, 7.0.5 Feb 21, 2023
@tmds
Copy link
Member

tmds commented Feb 22, 2023

Just an observation: the backport has the individual commits of the PR, rather than the squashed commit.
Probably it's always like that. I had not noticed before.

@carlossanlop
Copy link
Member

Probably it's always like that. I had not noticed before.

It's expected. The squash happens when we merge these PRs into the servicing branches.

@tmds @adamsitnik I noticed there are no unit tests. I assume we can only add them after we add the new Fedora RID. Correct?

Anyway:

  • Tested manually by Tom with Fedora 38.
  • Approved by Tactics.
  • Signed-off by area owner.
  • No OOB changes needed for this assembly.
  • CI is flawlessly green., nice.

So this is ready to merge. :shipit:

@carlossanlop carlossanlop merged commit a03dfad into release/7.0 Mar 8, 2023
@carlossanlop carlossanlop deleted the backport/pr-82038-to-release/7.0 branch March 8, 2023 18:09
@ghost ghost locked as resolved and limited conversation to collaborators Apr 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@adamsitnik adamsitnik adamsitnik approved these changes

@tmds tmds tmds approved these changes

@jozkee jozkee Awaiting requested review from jozkee

Assignees

@adamsitnik adamsitnik

Labels
area-System.Console Servicing-approved Approved for servicing release
Projects
None yet
Milestone
7.0.5
Development

Successfully merging this pull request may close these issues.
4 participants
@tmds @carlossanlop @adamsitnik @leecow